Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1521503002: Update bisect_lib with the changes committed in the infra/build repo. (Closed)

Created:
5 years ago by qyearsley
Modified:
5 years ago
Reviewers:
sullivan, RobertoCN
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : In README: add back license header, add link to Telemetry docs in catapult #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -584 lines) Patch
M experimental/bisect_lib/README.md View 1 2 chunks +1 line, -11 lines 0 comments Download
A + experimental/bisect_lib/bin/run_py_tests View 2 chunks +3 lines, -3 lines 0 comments Download
D experimental/bisect_lib/bisect_helper.py View 1 chunk +0 lines, -25 lines 0 comments Download
D experimental/bisect_lib/chromium_revisions.py View 1 chunk +0 lines, -56 lines 0 comments Download
D experimental/bisect_lib/chromium_revisions_test.py View 1 chunk +0 lines, -95 lines 0 comments Download
A experimental/bisect_lib/depot_map.py View 1 chunk +19 lines, -0 lines 0 comments Download
A experimental/bisect_lib/fetch_intervening_revisions.py View 1 chunk +102 lines, -0 lines 0 comments Download
A experimental/bisect_lib/fetch_intervening_revisions_test.py View 1 chunk +73 lines, -0 lines 0 comments Download
A experimental/bisect_lib/fetch_revision_info.py View 1 chunk +52 lines, -0 lines 0 comments Download
A experimental/bisect_lib/fetch_revision_info_test.py View 1 chunk +49 lines, -0 lines 0 comments Download
M experimental/bisect_lib/test_data/MOCK_INFO_RESPONSE_FILE View 1 chunk +48 lines, -48 lines 0 comments Download
A + experimental/bisect_lib/test_data/MOCK_RANGE_RESPONSE_1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A experimental/bisect_lib/test_data/MOCK_RANGE_RESPONSE_2_PAGE_1 View 1 chunk +42 lines, -0 lines 0 comments Download
A experimental/bisect_lib/test_data/MOCK_RANGE_RESPONSE_2_PAGE_2 View 1 chunk +41 lines, -0 lines 0 comments Download
D experimental/bisect_lib/test_data/MOCK_RANGE_RESPONSE_FILE View 1 chunk +0 lines, -347 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
qyearsley
5 years ago (2015-12-10 23:52:33 UTC) #2
sullivan
https://codereview.chromium.org/1521503002/diff/1/experimental/bisect_lib/README.md File experimental/bisect_lib/README.md (left): https://codereview.chromium.org/1521503002/diff/1/experimental/bisect_lib/README.md#oldcode5 experimental/bisect_lib/README.md:5: --> Why is this being removed? https://codereview.chromium.org/1521503002/diff/1/experimental/bisect_lib/README.md File experimental/bisect_lib/README.md ...
5 years ago (2015-12-11 20:13:25 UTC) #3
qyearsley
https://codereview.chromium.org/1521503002/diff/1/experimental/bisect_lib/README.md File experimental/bisect_lib/README.md (left): https://codereview.chromium.org/1521503002/diff/1/experimental/bisect_lib/README.md#oldcode5 experimental/bisect_lib/README.md:5: --> On 2015/12/11 20:13:24, sullivan wrote: > Why is ...
5 years ago (2015-12-14 18:29:18 UTC) #4
RobertoCN
This looks good to me.
5 years ago (2015-12-15 20:04:40 UTC) #5
sullivan
lgtm
5 years ago (2015-12-15 20:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521503002/20001
5 years ago (2015-12-15 21:26:00 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 21:38:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698