Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1521473002: Make metro_driver_unittests build with clang/win. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make metro_driver_unittests build with clang/win. Explicit specializations must not have a storage class. Since the whole thing is in an unnamed namespace anyway, drop it on the template declaration too. ..\..\win8\metro_driver\winrt_utils_unittest.cc(19,16) : error: explicit specialization cannot have a storage class [-W error] static HRESULT CreateProperty<const wchar_t*>( ~~~~~~~ ^ BUG=82385 Committed: https://crrev.com/acd148966bcdf4087db82bbaac36b8ea082faa53 Cr-Commit-Position: refs/heads/master@{#364543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M win8/metro_driver/winrt_utils_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
5 years ago (2015-12-10 23:16:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521473002/1
5 years ago (2015-12-10 23:18:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 23:45:57 UTC) #6
robertshield
lgtm
5 years ago (2015-12-10 23:56:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521473002/1
5 years ago (2015-12-10 23:59:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 00:23:48 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-11 00:25:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acd148966bcdf4087db82bbaac36b8ea082faa53
Cr-Commit-Position: refs/heads/master@{#364543}

Powered by Google App Engine
This is Rietveld 408576698