Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1521443002: Remove IAccessible2Proxy (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IAccessible2Proxy It was added for chrome frame testing, but chrome frame is no more. Nothing depends on this target nowadays. It doesn't build with clang/win, and the only reason we didn't notice is because the 'all' target doesn't include all targets in gyp. The gn build gets this right. Since this target doesn't build with clang/win and is unused, just delete it. BUG=82385 Committed: https://crrev.com/08cd0dff06d075273155efa5f724434521224232 Cr-Commit-Position: refs/heads/master@{#364511}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -72 lines) Patch
M third_party/iaccessible2/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/iaccessible2/IAccessible2Proxy.def View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/iaccessible2/README.chromium View 1 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/iaccessible2/iaccessible2.gyp View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
cf http://src.chromium.org/viewvc/chrome?revision=68680&view=revision
5 years ago (2015-12-10 21:47:43 UTC) #2
Dirk Pranke
lgtm
5 years ago (2015-12-10 22:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521443002/20001
5 years ago (2015-12-10 22:03:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 22:40:52 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 22:41:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08cd0dff06d075273155efa5f724434521224232
Cr-Commit-Position: refs/heads/master@{#364511}

Powered by Google App Engine
This is Rietveld 408576698