Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js

Issue 1521433002: [MediaRouter UI] Compile MR WebUI js code with Closure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed 2nd comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js b/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js
index d9fa92458be22ac3553b89c818d07d6aa8cd006f..54b3fd4a737e9fbcad5eed3f0f7a2e3afaa8c8f8 100644
--- a/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js
@@ -246,11 +246,12 @@
/**
* Returns false if the element is required and does not have a selection,
* and true otherwise.
+ * @param {Object} ignored
* @return {boolean} true if `required` is false, or if `required` is true
* and the element has a valid selection.
*/
- _getValidity: function() {
- return this.disabled || !this.required || (this.required && this.value);
+ _getValidity: function(ignored) {
Dan Beam 2015/12/12 01:43:02 lgtm if you revert this
imcheng 2015/12/14 22:47:00 Done.
+ return this.disabled || !this.required || (this.required && !!this.value);
},
_openedChanged: function() {
@@ -261,4 +262,4 @@
}
}
});
- })();
+ })();

Powered by Google App Engine
This is Rietveld 408576698