Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js

Issue 1521433002: [MediaRouter UI] Compile MR WebUI js code with Closure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase again Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
index f0025f77eec812666640334fda77bd73b3aafc18..3e9ea19c5e6d8a58fd6d3d5be0409a15627b6361 100644
--- a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
+++ b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
@@ -37,11 +37,11 @@ Polymer({
/**
* The current view that this header should reflect.
- * @type {media_router.MediaRouterView}
+ * @type {?media_router.MediaRouterView}
*/
view: {
type: String,
- value: '',
+ value: null,
},
/**
@@ -61,7 +61,7 @@ Polymer({
},
/**
- * @param {media_router.MediaRouterView} view The current view.
+ * @param {?media_router.MediaRouterView} view The current view.
* @return {string} The current arrow-drop-* icon to use.
* @private
*/
@@ -71,8 +71,8 @@ Polymer({
},
/**
- * @param {media_router.MediaRouterView} view The current view.
- * @return {string} Whether or not the arrow drop icon should be hidden.
+ * @param {?media_router.MediaRouterView} view The current view.
+ * @return {boolean} Whether or not the arrow drop icon should be hidden.
* @private
*/
computeArrowDropIconHidden_: function(view) {
@@ -81,8 +81,8 @@ Polymer({
},
/**
- * @param {media_router.MediaRouterView} view The current view.
- * @return {string} Whether or not the back button should be hidden.
+ * @param {?media_router.MediaRouterView} view The current view.
+ * @return {boolean} Whether or not the back button should be hidden.
* @private
*/
computeBackButtonHidden_: function(view) {

Powered by Google App Engine
This is Rietveld 408576698