Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4811)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 152143009: Clarify settings UI in multi-profiles mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index cc01414f19c8147c0156f394c0a52791de7edb93..1df186d1150198c902b71cde4ebf9420deee5a5a 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -77,8 +77,11 @@ cr.define('options', function() {
$('advanced-settings').addEventListener('webkitTransitionEnd',
this.updateAdvancedSettingsExpander_.bind(this));
- if (cr.isChromeOS)
+ if (cr.isChromeOS) {
UIAccountTweaks.applyGuestModeVisibility(document);
+ if (loadTimeData.getBoolean('secondaryUser'))
+ $('secondary-user-banner').hidden = false;
+ }
// Sync (Sign in) section.
this.updateSyncState_(loadTimeData.getValue('syncData'));
@@ -98,6 +101,18 @@ cr.define('options', function() {
// Internet connection section (ChromeOS only).
if (cr.isChromeOS) {
options.network.NetworkList.decorate($('network-list'));
+ // Show that the network settings are shared if this is a secondary user
+ // in a multi-profile session.
+ if (loadTimeData.getBoolean('secondaryUser')) {
+ // Create a synthetic pref change event decorated as
+ // CoreOptionsHandler::CreateValueForPref() does.
+ var event = new Event('network-section');
+ event.value = { controlledBy: 'shared' };
+ var networkIndicator = document.querySelector(
+ '#network-section-header > .controlled-setting-indicator');
+ networkIndicator.location = cr.ui.ArrowLocation.TOP_START;
+ networkIndicator.handlePrefChange(event);
+ }
options.network.NetworkList.refreshNetworkData(
loadTimeData.getValue('networkData'));
}
@@ -230,6 +245,11 @@ cr.define('options', function() {
chrome.send('coreOptionsUserMetricsAction',
['Options_ManageAccounts']);
};
+
+ document.querySelector(
+ '#enable-screen-lock + span > .controlled-setting-indicator').
+ setAttribute('textshared',
+ loadTimeData.getString('screenLockShared'));
} else {
$('import-data').onclick = function(event) {
ImportDataOverlay.show();

Powered by Google App Engine
This is Rietveld 408576698