Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2964)

Unified Diff: chrome/browser/ui/browser.cc

Issue 152143003: [ProtocolHandlers] Add a permission bubble client for RPH requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 46a8e6495b000cf5aa89635ad2310fac9c224019..858522500b4bb47f0c1ee4a861ed8fb176a51062 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1622,8 +1622,7 @@ void Browser::RegisterProtocolHandler(WebContents* web_contents,
window_->GetLocationBar()->UpdateContentSettingsIcons();
}
- RegisterProtocolHandlerInfoBarDelegate::Create(
- InfoBarService::FromWebContents(web_contents), registry, handler);
+ registry->RequestPermission(web_contents, handler);
koz (OOO until 15th September) 2014/02/06 03:03:26 Better to not add RequestPermission() to ProtocolH
Greg Billock 2014/02/06 22:23:49 This is intended to contain the bubble/infobar spl
koz (OOO until 15th September) 2014/02/06 23:34:10 Yes please. I think it would make more sense to ha
Greg Billock 2014/02/10 23:12:51 Sounds good. The context is that I've been doing
koz (OOO until 15th September) 2014/02/11 02:17:07 Yeah, it's probably not, but I'd be afraid of more
}
void Browser::UpdatePreferredSize(WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698