Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Unified Diff: cc/playback/display_item_proto_factory.cc

Issue 1521373005: Revert of cc: Shrink size of display item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/display_item_proto_factory.h ('k') | cc/playback/drawing_display_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_proto_factory.cc
diff --git a/cc/playback/display_item_proto_factory.cc b/cc/playback/display_item_proto_factory.cc
index 88d5066ce170dae83a884893a296a703596c73cd..fa5c0d8d61f6ac0d4a494c9205dd08f8ed9e88ba 100644
--- a/cc/playback/display_item_proto_factory.cc
+++ b/cc/playback/display_item_proto_factory.cc
@@ -17,53 +17,41 @@
namespace cc {
// static
-void DisplayItemProtoFactory::AllocateAndConstruct(
+DisplayItem* DisplayItemProtoFactory::AllocateAndConstruct(
const gfx::Rect& visual_rect,
DisplayItemList* list,
const proto::DisplayItem& proto) {
switch (proto.type()) {
case proto::DisplayItem::Type_Clip:
- list->CreateAndAppendItem<ClipDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<ClipDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndClip:
- list->CreateAndAppendItem<EndClipDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndClipDisplayItem>(visual_rect);
case proto::DisplayItem::Type_ClipPath:
- list->CreateAndAppendItem<ClipPathDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<ClipPathDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndClipPath:
- list->CreateAndAppendItem<EndClipPathDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndClipPathDisplayItem>(visual_rect);
case proto::DisplayItem::Type_Compositing:
- list->CreateAndAppendItem<CompositingDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<CompositingDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndCompositing:
- list->CreateAndAppendItem<EndCompositingDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndCompositingDisplayItem>(visual_rect);
case proto::DisplayItem::Type_Drawing:
- list->CreateAndAppendItem<DrawingDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<DrawingDisplayItem>(visual_rect);
case proto::DisplayItem::Type_Filter:
- list->CreateAndAppendItem<FilterDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<FilterDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndFilter:
- list->CreateAndAppendItem<EndFilterDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndFilterDisplayItem>(visual_rect);
case proto::DisplayItem::Type_FloatClip:
- list->CreateAndAppendItem<FloatClipDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<FloatClipDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndFloatClip:
- list->CreateAndAppendItem<EndFloatClipDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndFloatClipDisplayItem>(visual_rect);
case proto::DisplayItem::Type_Transform:
- list->CreateAndAppendItem<TransformDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<TransformDisplayItem>(visual_rect);
case proto::DisplayItem::Type_EndTransform:
- list->CreateAndAppendItem<EndTransformDisplayItem>(visual_rect, proto);
- return;
+ return list->CreateAndAppendItem<EndTransformDisplayItem>(visual_rect);
}
NOTREACHED();
+ return nullptr;
}
} // namespace cc
« no previous file with comments | « cc/playback/display_item_proto_factory.h ('k') | cc/playback/drawing_display_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698