Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1521363003: [turbofan] Unify pipeline entry for all assemblers. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify pipeline entry for all assemblers. This uses the same pipeline entry function for all three assemblers currently supported by TurboFan. The Pipeline::GenerateCodeForCodeStub is by now generic enough to accommodate all uses. R=vogelheim@chromium.org Committed: https://crrev.com/a0f7cafa6f28baec69a5084824b509472afbf7e4 Cr-Commit-Position: refs/heads/master@{#32837}

Patch Set 1 #

Patch Set 2 : Fix stats tracing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/compiler/fast-accessor-assembler.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
5 years ago (2015-12-14 12:53:01 UTC) #2
vogelheim
lgtm
5 years ago (2015-12-14 12:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521363003/20001
5 years ago (2015-12-14 13:39:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 13:45:57 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-14 13:46:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0f7cafa6f28baec69a5084824b509472afbf7e4
Cr-Commit-Position: refs/heads/master@{#32837}

Powered by Google App Engine
This is Rietveld 408576698