Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152133004: Update WebNode::getElementsByTagName() callers to use a WebNodeCollection (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, android-webview-reviews_chromium.org, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Update WebNode::getElementsByTagName() callers to use a WebNodeCollection Update WebNode::getElementsByTagName() callers to use a WebNodeCollection instead of a WebNodeList. The WebNode::getElementsByTagName() public API was updated in Blink r166263 to return a WebNodeCollection instead of a WebNodeList. Callers need to be updated so that we can get rid of the current workaround allowing a WebNodeList to be implicitly converted into a WebNodeCollection. BUG=235008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M android_webview/renderer/aw_render_view_ext.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Inactive
6 years, 10 months ago (2014-02-03 16:21:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-03 18:34:24 UTC) #2
benm (inactive)
lgtm
6 years, 10 months ago (2014-02-03 18:38:10 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-03 18:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/152133004/1
6 years, 10 months ago (2014-02-03 18:41:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 20:08:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255712
6 years, 10 months ago (2014-02-03 20:08:28 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:08:40 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:08:41 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-03 20:10:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/152133004/1
6 years, 10 months ago (2014-02-03 20:11:23 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:40:25 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:40:25 UTC) #13
commit-bot: I haz the power
Change committed as 248613
6 years, 10 months ago (2014-02-03 23:40:26 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:40:26 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:40:30 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 23:40:33 UTC) #17
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698