third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 1521323002: Show custom properties in the computed style pane of the inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 1521323002: Show custom properties in the computed style pane of the inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nicer test. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt ('K') | « third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index da497fdda56c1c08a7122a6283a7926e3abd0a7b..306d72ca77431226d0553fd78c10b08dcbafd065 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -534,6 +534,11 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

return ComputedStyleCSSValueMapping::get(customPropertyName, *computeComputedStyle());

}

+const HashMap<AtomicString, RefPtr<CSSVariableData>>* CSSComputedStyleDeclaration::getVariables() const

+ return ComputedStyleCSSValueMapping::getVariables(*computeComputedStyle());

PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropertyID propertyID) const

{

Node* styledNode = this->styledNode();