Show custom properties in the computed style pane of the inspector.

Show custom properties in the computed style pane of the inspector.

BUG=465126
Committed: https://crrev.com/2a9ce42ea227c59df51704d988ff887e2f6011e3
Cr-Commit-Position: refs/heads/master@{#365964}

[shans, 2015-12-14 00:29:28]

shans@chromium.org changed reviewers:
+ timloh@chromium.org

[shans, 2015-12-14 00:29:28]

Tim: once you've reviewed the CSS changes I'll pass it on to Sam to look at the
inspector stuff.

I'm not super happy with this for two reasons:

(1) I needed to expose the variable HashMap in order to be able to iterate over
the names of the variables.
(2) I needed to add the variables into the inspector's list of properties in a
different place to all the standard properties, because down where the inspector
code adds standard properties it's already forgotten that it's extracting
information from the Computed Style object.

So .. suggestions welcome!

[Timothy Loh, 2015-12-14 02:13:00]

core/css lgtm

On 2015/12/14 00:29:28, shans wrote:
> (1) I needed to expose the variable HashMap in order to be able to iterate
over
> the names of the variables.

Not sure if there's a better alternative :\

[Timothy Loh, 2015-12-14 02:13:17]

On 2015/12/14 02:13:00, Timothy Loh wrote:
> core/css lgtm

(and core/style)

[shans, 2015-12-14 02:17:26]

shans@chromium.org changed reviewers:
+ samli@chromium.org
- timloh@chromium.org

[samli, 2015-12-14 02:34:42]

samli@chromium.org changed reviewers:
+ timloh@chromium.org

[samli, 2015-12-14 02:34:42]

Let's add an inspector test. See
inspector/elements/styles-3/styles-computed-trace.html for a reference.

[samli, 2015-12-15 04:37:11]

samli@chromium.org changed reviewers:
+ pfeldman@chromium.org

[samli, 2015-12-15 04:37:12]

Looks much better, thanks! lgtm

@pfeldman, PTAL.

[pfeldman, 2015-12-16 00:44:16]

https://codereview.chromium.org/1521323002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt
(right):

https://codereview.chromium.org/1521323002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt:5:
44px - #id1 styles-variables.html:14 -> styles-variables.html:14:1
This test is going to be vulnerable to changes unrelated to css variables. Can
we trim everything that is not related?

[shans, 2015-12-16 04:58:53]

On 2015/12/16 at 00:44:16, pfeldman wrote:
>
https://codereview.chromium.org/1521323002/diff/60001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt
(right):
> 
>
https://codereview.chromium.org/1521323002/diff/60001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt:5:
44px - #id1 styles-variables.html:14 -> styles-variables.html:14:1
> This test is going to be vulnerable to changes unrelated to css variables. Can
we trim everything that is not related?

Done, PTAL.

[pfeldman, 2015-12-17 20:28:48]

lgtm

[samli, 2015-12-17 22:54:39]

The CQ bit was checked by samli@chromium.org

[samli, 2015-12-17 22:54:39]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
samli@chromium.org
Link to the patchset: https://codereview.chromium.org/1521323002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 22:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1521323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1521323002/80001

[commit-bot: I haz the power, 2015-12-18 01:25:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-18 01:26:42]

Description was changed from

==========
Show custom properties in the computed style pane of the inspector.

BUG=465126
==========

to

==========
Show custom properties in the computed style pane of the inspector.

BUG=465126

Committed: https://crrev.com/2a9ce42ea227c59df51704d988ff887e2f6011e3
Cr-Commit-Position: refs/heads/master@{#365964}
==========

[commit-bot: I haz the power, 2015-12-18 01:26:43]

Patchset 5 (id:??) landed as
https://crrev.com/2a9ce42ea227c59df51704d988ff887e2f6011e3
Cr-Commit-Position: refs/heads/master@{#365964}