Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1521283003: Run browser tests on Atom/Electron (Closed)

Created:
5 years ago by vsm
Modified:
5 years ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run browser tests on Atom/Electron Tested on travis here: https://travis-ci.org/dart-lang/dev_compiler/builds/96609818 Note, electron shows up in the log as: Chrome 47.0.2526 This fixes #395 R=ochafik@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/edca710e26775891d26e4beff841123719ff30aa

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M karma.conf.js View 3 chunks +3 lines, -3 lines 1 comment Download
M lib/runtime/dart_library.js View 2 chunks +6 lines, -4 lines 1 comment Download
M package.json View 1 chunk +2 lines, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +12 lines, -2 lines 0 comments Download
M tool/browser_test.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
https://codereview.chromium.org/1521283003/diff/1/karma.conf.js File karma.conf.js (right): https://codereview.chromium.org/1521283003/diff/1/karma.conf.js#newcode31 karma.conf.js:31: 'test/codegen/expect/language-all.js', Karma ships each file as a separate script ...
5 years ago (2015-12-14 01:15:07 UTC) #3
ochafik
lgtm, that's cool! https://codereview.chromium.org/1521283003/diff/1/lib/runtime/dart_library.js File lib/runtime/dart_library.js (right): https://codereview.chromium.org/1521283003/diff/1/lib/runtime/dart_library.js#newcode54 lib/runtime/dart_library.js:54: let lib = libraries.get(name); Electron doesn't ...
5 years ago (2015-12-14 02:46:16 UTC) #4
vsm
Committed patchset #1 (id:1) manually as edca710e26775891d26e4beff841123719ff30aa (presubmit successful).
5 years ago (2015-12-14 14:25:29 UTC) #6
vsm
5 years ago (2015-12-14 16:48:25 UTC) #7
Message was sent while issue was closed.
On 2015/12/14 02:46:16, ochafik wrote:
> lgtm, that's cool!
> 
> https://codereview.chromium.org/1521283003/diff/1/lib/runtime/dart_library.js
> File lib/runtime/dart_library.js (right):
> 
>
https://codereview.chromium.org/1521283003/diff/1/lib/runtime/dart_library.js...
> lib/runtime/dart_library.js:54: let lib = libraries.get(name);
> Electron doesn't like [] on Map yet?

I don't think these APIs are intended to be mixed and matched.  E.g., from a
Chrome console:

> var map = new Map()
undefined
> map.set(2, 3)
Map {2 => 3}
> map[4] = 3
3
> map
Map {2 => 3}
> map[2]
undefined

Powered by Google App Engine
This is Rietveld 408576698