Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1521233002: mac ninja&make: Use xcrun instead of xcodebuild where possible. (Closed)

Created:
5 years ago by Nico
Modified:
4 years, 11 months ago
CC:
gyp-developer_googlegroups.com, justincohen, scottmg
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

mac ninja&make: Use xcrun instead of xcodebuild where possible. We used to not use xcrun because it used to not exist long ago. Nowadays, xcrun should be present everywhere (Xcode 5+ I think) and it's much faster. Running `python gyptest.py -a -f ninja` on my laptop takes 5 minutes without this patch and 3m20s with it. No intended behavior change. BUG=none R=mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/54b7dfc03f746b6a539ac38f2fb0815d10b54734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M pylib/gyp/xcode_emulation.py View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Justin: This should work on iOS too, right?
5 years ago (2015-12-13 04:09:11 UTC) #2
Mark Mentovai
LGTM
5 years ago (2015-12-13 15:23:22 UTC) #3
justincohen
Yup, xcrun should be fine on iOS.
5 years ago (2015-12-14 07:14:11 UTC) #5
Nico
4 years, 11 months ago (2016-01-14 17:26:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54b7dfc03f746b6a539ac38f2fb0815d10b54734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698