Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: components/offline_pages/offline_page_test_archiver.cc

Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing final CR feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_test_archiver.cc
diff --git a/components/offline_pages/offline_page_test_archiver.cc b/components/offline_pages/offline_page_test_archiver.cc
index 6dfe954390299762b948ef9b3d907d3b2bd57d39..e26467c59f448f9189e3c48d3e4018d9f0d69702 100644
--- a/components/offline_pages/offline_page_test_archiver.cc
+++ b/components/offline_pages/offline_page_test_archiver.cc
@@ -43,7 +43,13 @@ void OfflinePageTestArchiver::CreateArchive(
void OfflinePageTestArchiver::CompleteCreateArchive() {
DCHECK(!callback_.is_null());
base::FilePath archive_path;
- ASSERT_TRUE(base::CreateTemporaryFileInDir(archives_dir_, &archive_path));
+ if (filename_.empty()) {
+ ASSERT_TRUE(base::CreateTemporaryFileInDir(archives_dir_, &archive_path));
+ } else {
+ archive_path = archives_dir_.Append(filename_);
+ // This step ensures the file is created and closed immediately.
+ base::File file(archive_path, base::File::FLAG_OPEN_ALWAYS);
+ }
observer_->SetLastPathCreatedByArchiver(archive_path);
task_runner_->PostTask(FROM_HERE, base::Bind(callback_, this, result_, url_,
archive_path, size_to_report_));
« no previous file with comments | « components/offline_pages/offline_page_test_archiver.h ('k') | components/offline_pages/offline_page_test_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698