[Offline pages] Refactor URL conversions from TabAndroid

chrome/browser/android/offline_pages/offline_page_utils.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_UTILS_H_
+#define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_UTILS_H_
+
+#include "base/basictypes.h"
+
+class GURL;
+
+namespace content {
+class BrowserContext;
+}
+
+namespace offline_pages {
+struct OfflinePageItem;
+
+class OfflinePageUtils {
+ public:
+  // Returns true if |url| might point to an offline page.
+  static bool MightBeOfflineURL(const GURL& url);
+
+  // Gets an offline URL of an offline page with |online_url| if one is present
+  // in the |browser_context|.
+  static GURL GetOfflineURLByOnlineURL(content::BrowserContext* browser_context,

[newt (away), 2015/12/17 03:08:45]

"By" doesn't seem like the right preposition. Maybe use "For" or "From"?

[fgorski, 2015/12/17 19:00:14]

Done.

+                                       const GURL& online_url);
+
+  // Gets an online URL of an offline page with |offline_url| if one is present
+  // in

[newt (away), 2015/12/17 03:08:45]

nit: wrapping

[fgorski, 2015/12/17 19:00:14]

Done.

+  // the |browser_context|.
+  static GURL GetOnlineURLByOfflineURL(content::BrowserContext* browser_context,
+                                       const GURL& offline_url);
+
+  // Gets a bookmark ID related to the |offline_url|.
+  static int64 GetBookmarkIdByOfflineURL(
+      content::BrowserContext* browser_context,
+      const GURL& offline_url);
+
+  // Checks whether a given |offline_url| points to an offline page.

[jianli, 2015/12/16 23:08:07]

nit: drop "given"

[fgorski, 2015/12/17 19:00:14]

Done.

+  static bool IsOfflinePage(content::BrowserContext* browser_context,
+                            const GURL& offline_url);
+
+  // Checks whether a given |online_url| has a related offline page.

[jianli, 2015/12/16 23:08:07]

nit: "related to" sounds a bit not intuitive. Also no need to use "given" when
you specify the parameter name. How about:
  Checks whether an offline page for |online_url| exists or not.

[fgorski, 2015/12/17 19:00:14]

Done.

+  static bool HasOfflinePageForOnlineURL(
+      content::BrowserContext* browser_context,
+      const GURL& online_url);
+
+  // Checks if there are any offline pages saved in the |browser_context|

[jianli, 2015/12/16 23:08:07]

nit: suggest dropping the comment for browser_context since you do not add this
everywhere.

[fgorski, 2015/12/17 19:00:14]

Done.

+  static const bool HasOfflinePages(content::BrowserContext* browser_context);
+};
+
+}  // namespace offline_pages
+
+#endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_UTILS_H_