[Offline pages] Refactor URL conversions from TabAndroid

components/offline_pages/offline_page_test_store.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_test_store.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 12 matching lines @@
 OfflinePageTestStore::~OfflinePageTestStore() {}
 
 void OfflinePageTestStore::Load(const LoadCallback& callback) {
   OfflinePageMetadataStore::LoadStatus load_status;
   if (scenario_ == TestScenario::LOAD_FAILED) {
     load_status = OfflinePageMetadataStore::STORE_LOAD_FAILED;
     offline_pages_.clear();
   } else {
     load_status = OfflinePageMetadataStore::LOAD_SUCCEEDED;
   }
+  DVLOG(1) << "Size of offline pages in store: " << offline_pages_.size();
   task_runner_->PostTask(FROM_HERE,
                          base::Bind(callback, load_status, GetAllPages()));
 }
 
 void OfflinePageTestStore::AddOrUpdateOfflinePage(
     const OfflinePageItem& offline_page,
     const UpdateCallback& callback) {
   last_saved_page_ = offline_page;
   bool result = scenario_ != TestScenario::WRITE_FAILED;
   if (result)
@@ skipping 33 matching lines @@
   iter->second.last_access_time = last_access_time;
 }
 
 std::vector<OfflinePageItem> OfflinePageTestStore::GetAllPages() const {
   std::vector<OfflinePageItem> offline_pages;
   for (const auto& id_page_pair : offline_pages_)
     offline_pages.push_back(id_page_pair.second);
   return offline_pages;
 }
 
+void OfflinePageTestStore::SetStoreState(

[jianli, 2015/12/15 01:45:25]

I am not sure we need this. Why not just calling AddOrUpdateOfflinePage to add a
bunch items? You can update AddOrUpdateOfflinePage to skip calling PostTask if
provided callback is empty.

[fgorski, 2015/12/15 16:33:02]

Done.

+    const std::vector<OfflinePageItem>& offline_pages) {
+  offline_pages_.clear();
+  for (const auto& offline_page : offline_pages) {
+    offline_pages_[offline_page.bookmark_id] = offline_page;
+  }
+}
+
 }  // namespace offline_pages