[Offline pages] Refactor URL conversions from TabAndroid

chrome/browser/android/tab_android.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/tab_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/metrics/histogram.h"
 #include "base/trace_event/trace_event.h"
 #include "cc/layers/layer.h"
 #include "chrome/browser/android/compositor/tab_content_manager.h"
 #include "chrome/browser/android/metrics/uma_utils.h"
-#include "chrome/browser/android/offline_pages/offline_page_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
+#include "chrome/browser/android/offline_pages/offline_page_utils.h"
 #include "chrome/browser/android/tab_web_contents_delegate_android.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
 #include "chrome/browser/browser_about_handler.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
@@ skipping 740 matching lines @@
                                 jboolean only_editable) {
   return GetBookmarkIdHelper(only_editable);
 }
 
 int64_t TabAndroid::GetBookmarkIdHelper(bool only_editable) const {
   GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
       web_contents()->GetURL());
   Profile* profile = GetProfile();
 
   // If the url points to an offline page, replace it with the original url.
-  const offline_pages::OfflinePageItem* offline_page = GetOfflinePage(url);
-  if (offline_page)
-    url = offline_page->url;
+  int64_t offline_page_bookmark_id =
+      offline_pages::android::GetBookmarkIdByOfflineURL(GetProfile(), url);
+  // When found, return immediately, as offline copy only belongs to a single
+  // bookmark.
+  if (offline_page_bookmark_id != -1)

[jianli, 2015/12/15 01:45:24]

What if offline_page_bookmark_id cannot be found in bookmark model when the
offline meta store fails to removes its record for various reasons?

[fgorski, 2015/12/15 16:33:02]

Updated.
I have a separate patch(es) where I'll be addressing that problem more broadly.

+    return offline_page_bookmark_id;
 
   // Get all the nodes for |url| and sort them by date added.
   std::vector<const bookmarks::BookmarkNode*> nodes;
   bookmarks::ManagedBookmarkService* managed =
       ManagedBookmarkServiceFactory::GetForProfile(profile);
   bookmarks::BookmarkModel* model =
       BookmarkModelFactory::GetForProfile(profile);
   model->GetNodesByURL(url, &nodes);
   std::sort(nodes.begin(), nodes.end(), &bookmarks::MoreRecentlyAdded);
 
   // Return the first node matching the search criteria.
   for (size_t i = 0; i < nodes.size(); ++i) {
     if (only_editable && !managed->CanBeEditedByUser(nodes[i]))
       continue;
     return nodes[i]->id();
   }
 
   return -1;
 }
 
 bool TabAndroid::HasOfflinePages() const {
-  if (!offline_pages::IsOfflinePagesEnabled())
-    return false;
-  offline_pages::OfflinePageModel* offline_page_model =
-      offline_pages::OfflinePageModelFactory::GetForBrowserContext(
-          GetProfile());
-  return !offline_page_model->GetAllPages().empty();
+  return offline_pages::android::HasOfflinePages(GetProfile());
 }
 
 void TabAndroid::ShowOfflinePages() {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_Tab_showOfflinePages(env, weak_java_tab_.get(env).obj());
 }
 
 void TabAndroid::LoadOfflineCopy(const GURL& url) {
-  if (!offline_pages::IsOfflinePagesEnabled())
-    return;
-
-  // Offline copy is only saved for a bookmarked page.
-  int64_t bookmark_id = GetBookmarkIdHelper(true);
-  if (bookmark_id == -1)
-    return;
-
-  offline_pages::OfflinePageModel* offline_page_model =
-      offline_pages::OfflinePageModelFactory::GetForBrowserContext(
-          GetProfile());
-  if (!offline_page_model)
-    return;
-
-  const offline_pages::OfflinePageItem* offline_page =
-      offline_page_model->GetPageByBookmarkId(bookmark_id);
-  if (!offline_page || offline_page->url != url)
-    return;
-
-  GURL offline_url = offline_page->GetOfflineURL();
+  GURL offline_url =
+      offline_pages::android::GetOfflineURLByOnlineURL(GetProfile(), url);
   if (!offline_url.is_valid())
     return;
 
   content::NavigationController::LoadURLParams load_params(offline_url);
   web_contents()->GetController().LoadURLWithParams(load_params);
 }
 
 jboolean TabAndroid::HasOfflineCopy(JNIEnv* env,
                                     const JavaParamRef<jobject>& obj) {
-  // Offline copy is only saved for a bookmarked page.
-  int64_t bookmark_id = GetBookmarkIdHelper(true);
-  if (bookmark_id == -1)
-    return false;
-
-  offline_pages::OfflinePageModel* offline_page_model =
-      offline_pages::OfflinePageModelFactory::GetForBrowserContext(
-          GetProfile());
-  if (!offline_page_model)
-    return false;
-  const offline_pages::OfflinePageItem* offline_page =
-      offline_page_model->GetPageByBookmarkId(bookmark_id);
-  return offline_page && !offline_page->file_path.empty();
+  GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
+      web_contents()->GetURL());
+  return offline_pages::android::HasOfflinePageForOnlineURL(GetProfile(), url);
 }
 
 jboolean TabAndroid::IsOfflinePage(JNIEnv* env,
                                    const JavaParamRef<jobject>& obj) {
   GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
       web_contents()->GetURL());
-  return GetOfflinePage(url) != nullptr;
+  return offline_pages::android::IsOfflinePage(GetProfile(), url);
 }
 
 ScopedJavaLocalRef<jstring> TabAndroid::GetOfflinePageOriginalUrl(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
   GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
       web_contents()->GetURL());
-  const offline_pages::OfflinePageItem* offline_page = GetOfflinePage(url);
-  if (offline_page == nullptr)
+  GURL original_url =
+      offline_pages::android::GetOnlineURLByOfflineURL(GetProfile(), url);
+  if (!original_url.is_valid())
     return ScopedJavaLocalRef<jstring>();
 
   return ScopedJavaLocalRef<jstring>(
-      ConvertUTF8ToJavaString(env, offline_page->url.spec()));
-}
-
-const offline_pages::OfflinePageItem* TabAndroid::GetOfflinePage(
-    const GURL& url) const {
-  if (!offline_pages::IsOfflinePagesEnabled())
-    return nullptr;
-
-  // Note that we first check if the url likely points to an offline page
-  // before calling GetPageByOfflineURL in order to avoid unnecessary lookup
-  // cost.
-  if (!offline_pages::android::OfflinePageBridge::MightBeOfflineURL(url))
-    return nullptr;
-
-  offline_pages::OfflinePageModel* offline_page_model =
-      offline_pages::OfflinePageModelFactory::GetForBrowserContext(
-          GetProfile());
-  return offline_page_model->GetPageByOfflineURL(url);
+      ConvertUTF8ToJavaString(env, original_url.spec()));
 }
 
 bool TabAndroid::HasPrerenderedUrl(JNIEnv* env,
                                    const JavaParamRef<jobject>& obj,
                                    const JavaParamRef<jstring>& url) {
   GURL gurl(base::android::ConvertJavaStringToUTF8(env, url));
   return HasPrerenderedUrl(gurl);
 }
 
 namespace {
@@ skipping 71 matching lines @@
 static void Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   TRACE_EVENT0("native", "TabAndroid::Init");
   // This will automatically bind to the Java object and pass ownership there.
   new TabAndroid(env, obj);
 }
 
 // static
 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }