Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: components/offline_pages/offline_page_test_store.cc

Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing final CR feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/offline_page_test_archiver.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_test_store.h" 5 #include "components/offline_pages/offline_page_test_store.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 23 matching lines...) Expand all
34 base::Bind(callback, load_status, GetAllPages())); 34 base::Bind(callback, load_status, GetAllPages()));
35 } 35 }
36 36
37 void OfflinePageTestStore::AddOrUpdateOfflinePage( 37 void OfflinePageTestStore::AddOrUpdateOfflinePage(
38 const OfflinePageItem& offline_page, 38 const OfflinePageItem& offline_page,
39 const UpdateCallback& callback) { 39 const UpdateCallback& callback) {
40 last_saved_page_ = offline_page; 40 last_saved_page_ = offline_page;
41 bool result = scenario_ != TestScenario::WRITE_FAILED; 41 bool result = scenario_ != TestScenario::WRITE_FAILED;
42 if (result) 42 if (result)
43 offline_pages_[offline_page.bookmark_id] = offline_page; 43 offline_pages_[offline_page.bookmark_id] = offline_page;
44 task_runner_->PostTask(FROM_HERE, base::Bind(callback, result)); 44 if (!callback.is_null())
45 task_runner_->PostTask(FROM_HERE, base::Bind(callback, result));
45 } 46 }
46 47
47 void OfflinePageTestStore::RemoveOfflinePages( 48 void OfflinePageTestStore::RemoveOfflinePages(
48 const std::vector<int64>& bookmark_ids, 49 const std::vector<int64>& bookmark_ids,
49 const UpdateCallback& callback) { 50 const UpdateCallback& callback) {
50 ASSERT_FALSE(bookmark_ids.empty()); 51 ASSERT_FALSE(bookmark_ids.empty());
51 bool result = false; 52 bool result = false;
52 if (scenario_ != TestScenario::REMOVE_FAILED) { 53 if (scenario_ != TestScenario::REMOVE_FAILED) {
53 for (const auto& bookmark_id : bookmark_ids) { 54 for (const auto& bookmark_id : bookmark_ids) {
54 auto iter = offline_pages_.find(bookmark_id); 55 auto iter = offline_pages_.find(bookmark_id);
(...skipping 22 matching lines...) Expand all
77 } 78 }
78 79
79 std::vector<OfflinePageItem> OfflinePageTestStore::GetAllPages() const { 80 std::vector<OfflinePageItem> OfflinePageTestStore::GetAllPages() const {
80 std::vector<OfflinePageItem> offline_pages; 81 std::vector<OfflinePageItem> offline_pages;
81 for (const auto& id_page_pair : offline_pages_) 82 for (const auto& id_page_pair : offline_pages_)
82 offline_pages.push_back(id_page_pair.second); 83 offline_pages.push_back(id_page_pair.second);
83 return offline_pages; 84 return offline_pages;
84 } 85 }
85 86
86 } // namespace offline_pages 87 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_test_archiver.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698