Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1521023002: Remove use_aura build arg. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove use_aura build arg. (And also the ui_compositor_image_transport variable.) Note: You'll want to run "mojob.py gn" again (or manually remove the use_aura entry in args.gn. Otherwise, gn will yell at you. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d3482c6d25faabd04dffcea32d4dee18af74d600

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -152 lines) Patch
M base/test/test_suite.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M build/config/ui.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/tools/mopy/gn.py View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/tools/mopy/gn_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M tools/xdisplaycheck/xdisplaycheck.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/devices/x11/device_list_cache_x11.cc View 2 chunks +1 line, -17 lines 2 comments Download
D ui/events/gesture_detection/gesture_configuration_aura.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
https://codereview.chromium.org/1521023002/diff/1/ui/events/devices/x11/device_list_cache_x11.cc File ui/events/devices/x11/device_list_cache_x11.cc (right): https://codereview.chromium.org/1521023002/diff/1/ui/events/devices/x11/device_list_cache_x11.cc#newcode30 ui/events/devices/x11/device_list_cache_x11.cc:30: xi_dev_list_.devices.reset(); Possibly we should just get rid of xi_dev_list_, ...
5 years ago (2015-12-11 20:23:57 UTC) #1
jamesr
lgtm
5 years ago (2015-12-11 20:25:17 UTC) #2
viettrungluu
5 years ago (2015-12-11 20:31:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3482c6d25faabd04dffcea32d4dee18af74d600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698