Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 15210004: MIPS: Implement yield* (delegating yield) (Closed)

Created:
7 years, 7 months ago by palfia
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement yield* (delegating yield) Port r14669 (b64ce42a) Original commit message: Ideally this would have been implemented via desugaring at parse-time, but yield* is an expression, and its desugaring includes statements like while and try/catch. We'd have to have BlockExpression in the AST to support that, and it's not worth it for this feature. So instead we implement all of the logic in FullCodeGenerator::VisitYield. Delegating yield AST nodes now have a try handler index, for the try/catch. Otherwise the implementation is straightforward. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -2 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +102 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 7 months ago (2013-05-17 00:59:30 UTC) #1
Paul Lind
lgtm
7 years, 7 months ago (2013-05-17 01:09:12 UTC) #2
palfia
7 years, 7 months ago (2013-05-17 01:10:16 UTC) #3
Message was sent while issue was closed.
Committed manually as r14712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698