Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1520843002: Revert of Removes the Callee parameter from FunctionCallbackInfo. (Closed)

Created:
5 years ago by epertoso
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Removes the Callee parameter from FunctionCallbackInfo. (patchset #1 id:1 of https://codereview.chromium.org/1510483002/ ) Reason for revert: Need to figure out a better solution for this. Original issue's description: > Removes the Callee parameter from FunctionCallbackInfo. > > This will help us to instantiate AccessorPair's getters and setters only when they are needed. > > BUG= > > Committed: https://crrev.com/2fe34ebdcdee0f21b88daa4098a7918e91abb8fb > Cr-Commit-Position: refs/heads/master@{#32759} TBR=jochen@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/474ecd67eae43aa0f2af968547cee1f02543f313 Cr-Commit-Position: refs/heads/master@{#32787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -21 lines) Patch
M include/v8.h View 4 chunks +11 lines, -2 lines 0 comments Download
M src/arguments.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
epertoso
Created Revert of Removes the Callee parameter from FunctionCallbackInfo.
5 years ago (2015-12-11 10:19:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520843002/1
5 years ago (2015-12-11 10:19:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 10:20:11 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-11 10:21:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/474ecd67eae43aa0f2af968547cee1f02543f313
Cr-Commit-Position: refs/heads/master@{#32787}

Powered by Google App Engine
This is Rietveld 408576698