Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1520833004: Move perspective property into CSSPropertyParser (Closed)

Created:
5 years ago by rwlbuis
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move perspective property into CSSPropertyParser Move perspective property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/b1ea25cfb988c34c5ecaa08c264392cd7d11fda9 Cr-Commit-Position: refs/heads/master@{#367495}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
rwlbuis
PTAL
5 years ago (2015-12-17 03:40:25 UTC) #3
rwlbuis
On 2015/12/17 03:40:25, rwlbuis wrote: > PTAL PTAL whenever you have time. I verified that ...
4 years, 11 months ago (2016-01-04 15:17:01 UTC) #4
Timothy Loh
On 2016/01/04 15:17:01, rwlbuis wrote: > On 2015/12/17 03:40:25, rwlbuis wrote: > > PTAL > ...
4 years, 11 months ago (2016-01-05 02:26:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520833004/20001
4 years, 11 months ago (2016-01-05 04:46:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/4039)
4 years, 11 months ago (2016-01-05 07:03:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520833004/20001
4 years, 11 months ago (2016-01-05 07:18:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 08:21:06 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 08:22:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1ea25cfb988c34c5ecaa08c264392cd7d11fda9
Cr-Commit-Position: refs/heads/master@{#367495}

Powered by Google App Engine
This is Rietveld 408576698