Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1520793002: X87: [turbofan] Make MachineType a pair of enums. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Make MachineType a pair of enums. port bb2a830debbff19cf5a510c920ff9ac88d41355c (r32738) original commit message: MachineType is now a class with two enum fields: - MachineRepresentation - MachineSemantic Both enums are usable on their own, and this change switches some places from using MachineType to use just MachineRepresentation. Most notably: - register allocator now uses just the representation. - Phi and Select nodes only refer to representations. BUG= Committed: https://crrev.com/da7c5a739cfcc307400496973ebf2251bea16710 Cr-Commit-Position: refs/heads/master@{#32778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -61 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 8 chunks +43 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-11 03:29:20 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-11 04:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520793002/1
5 years ago (2015-12-11 04:45:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 05:07:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-11 05:07:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da7c5a739cfcc307400496973ebf2251bea16710
Cr-Commit-Position: refs/heads/master@{#32778}

Powered by Google App Engine
This is Rietveld 408576698