Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520773002: Int64 improvements (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
Chris Bracken
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Int64 improvements 1. Avoid test for JavaScript vs VM 2. strengthen & and | masking to help infer uint31 types in tests R=cbracken@google.com Committed: https://github.com/dart-lang/sdk/commit/231de7d3c20de57a0bfea3dbc75dd10795065115

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -49 lines) Patch
M pkg/fixnum/lib/src/int64.dart View 1 8 chunks +15 lines, -48 lines 0 comments Download
M pkg/fixnum/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years ago (2015-12-11 02:10:24 UTC) #2
Chris Bracken
lgtm https://codereview.chromium.org/1520773002/diff/1/pkg/fixnum/lib/src/int64.dart File pkg/fixnum/lib/src/int64.dart (right): https://codereview.chromium.org/1520773002/diff/1/pkg/fixnum/lib/src/int64.dart#newcode107 pkg/fixnum/lib/src/int64.dart:107: //return new Int64._bits(d0, d1, d2); delete https://codereview.chromium.org/1520773002/diff/1/pkg/fixnum/lib/src/int64.dart#newcode201 pkg/fixnum/lib/src/int64.dart:201: ...
5 years ago (2015-12-11 20:32:05 UTC) #3
sra1
5 years ago (2015-12-14 21:50:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
231de7d3c20de57a0bfea3dbc75dd10795065115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698