Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520563002: Generate settings_private_interface.js (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_563744_api_interfaces
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate settings_private_interface.js BUG=563744 Committed: https://crrev.com/1b74e1e0b71bdf2e724e85cb636e5de4082cc9d3 Cr-Commit-Position: refs/heads/master@{#364496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -66 lines) Patch
M chrome/browser/resources/settings/prefs/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/settings/settings_private_interface.js View 1 chunk +0 lines, -61 lines 0 comments Download
A + third_party/closure_compiler/externs/settings_private_interface.js View 1 chunk +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1488773003 Patch 200001

Messages

Total messages: 8 (3 generated)
stevenjb
5 years ago (2015-12-10 16:58:57 UTC) #2
michaelpg
nice, lgtm
5 years ago (2015-12-10 21:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520563002/1
5 years ago (2015-12-10 21:46:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 22:10:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 22:11:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1b74e1e0b71bdf2e724e85cb636e5de4082cc9d3
Cr-Commit-Position: refs/heads/master@{#364496}

Powered by Google App Engine
This is Rietveld 408576698