Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2758)

Unified Diff: chrome/browser/ssl/ssl_add_certificate.cc

Issue 1520543004: Add method for identifying different InfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_add_certificate.cc
diff --git a/chrome/browser/ssl/ssl_add_certificate.cc b/chrome/browser/ssl/ssl_add_certificate.cc
index 7b8d51eae950b5fe700f6668f44d818d0cb9d287..7f543e424604968cd4318b0637973573e299c2b9 100644
--- a/chrome/browser/ssl/ssl_add_certificate.cc
+++ b/chrome/browser/ssl/ssl_add_certificate.cc
@@ -44,6 +44,7 @@ class SSLAddCertificateInfoBarDelegate : public ConfirmInfoBarDelegate {
// ConfirmInfoBarDelegate:
Type GetInfoBarType() const override;
+ std::string GetIdentifier() const override;
int GetIconId() const override;
gfx::VectorIconId GetVectorIconId() const override;
base::string16 GetMessageText() const override;
@@ -78,6 +79,10 @@ SSLAddCertificateInfoBarDelegate::GetInfoBarType() const {
return PAGE_ACTION_TYPE;
}
+std::string SSLAddCertificateInfoBarDelegate::GetIdentifier() const {
+ return "SSLAddCertificateInfoBarDelegate";
+}
+
int SSLAddCertificateInfoBarDelegate::GetIconId() const {
// TODO(davidben): Use a more appropriate icon.
return IDR_INFOBAR_SAVE_PASSWORD;
@@ -130,7 +135,9 @@ void ShowErrorInfoBar(int message_id,
// TODO(davidben): Use a more appropriate icon.
// TODO(davidben): Display a more user-friendly error string.
SimpleAlertInfoBarDelegate::Create(
- InfoBarService::FromWebContents(web_contents), IDR_INFOBAR_SAVE_PASSWORD,
+ InfoBarService::FromWebContents(web_contents),
+ "SSLAddCertificate",
+ IDR_INFOBAR_SAVE_PASSWORD,
#if !defined(OS_MACOSX)
gfx::VectorIconId::AUTOLOGIN,
#else

Powered by Google App Engine
This is Rietveld 408576698