Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520523005: Oilpan: fix build after r364654, part 2. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r364654, part 2. Follow up r364678, unit test breakages. TBR=oilpan-reviews BUG=531990 NOTRY=true Committed: https://crrev.com/f42f0f8e15a6d96bd3a036cd16ada19a4498819a Cr-Commit-Position: refs/heads/master@{#364683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversalTest.cpp View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
how's the prioritized effort to get Oilpan under CQ control coming along?
5 years ago (2015-12-11 12:47:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520523005/1
5 years ago (2015-12-11 12:48:30 UTC) #3
haraken
LGTM. On 2015/12/11 12:47:53, sof wrote: > how's the prioritized effort to get Oilpan under ...
5 years ago (2015-12-11 12:52:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 12:53:00 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f42f0f8e15a6d96bd3a036cd16ada19a4498819a Cr-Commit-Position: refs/heads/master@{#364683}
5 years ago (2015-12-11 12:53:48 UTC) #7
sof
5 years ago (2015-12-11 12:54:47 UTC) #8
Message was sent while issue was closed. 
On 2015/12/11 12:52:35, haraken wrote:
> LGTM.
> 
> On 2015/12/11 12:47:53, sof wrote:
> > how's the prioritized effort to get Oilpan under CQ control coming along?
> 
> Dirk, Pawel and peria are actively working on it.

ok; I'm fed up & then some, having to waste time keeping the tree alive.

Powered by Google App Engine
This is Rietveld 408576698