Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1520513002: Fix missing guard (Closed)

Created:
5 years ago by sigurds
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix missing guard in native context specialization Native context specialization was missing an SSI renaming. R=jarin@chromium.org Committed: https://crrev.com/5aeb98efcf9b50da6f0be23a3dccea7146b8b28c Cr-Commit-Position: refs/heads/master@{#32771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
sigurds
As per offline discussion. PTAL
5 years ago (2015-12-10 15:06:35 UTC) #3
sigurds
As per offline discussion. PTAL
5 years ago (2015-12-10 15:06:37 UTC) #4
Jarin
lgtm
5 years ago (2015-12-10 17:55:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520513002/1
5 years ago (2015-12-10 20:32:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 22:53:07 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 22:53:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5aeb98efcf9b50da6f0be23a3dccea7146b8b28c
Cr-Commit-Position: refs/heads/master@{#32771}

Powered by Google App Engine
This is Rietveld 408576698