Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1520493002: Remove ScopedVector from address_sorter_posix (Closed)

Created:
5 years ago by Olli Raula
Modified:
5 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from address_sorter_posix BUG=554289 Committed: https://crrev.com/f660c2b4c8bf2e09964864054b172b45fc54dfee Cr-Commit-Position: refs/heads/master@{#364983}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M net/dns/address_sorter_posix.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Olli Raula
Could you review?
5 years ago (2015-12-11 13:20:26 UTC) #3
mmenke
LGTM https://codereview.chromium.org/1520493002/diff/1/net/dns/address_sorter_posix.cc File net/dns/address_sorter_posix.cc (right): https://codereview.chromium.org/1520493002/diff/1/net/dns/address_sorter_posix.cc#newcode9 net/dns/address_sorter_posix.cc:9: #include <vector> I think this should go down ...
5 years ago (2015-12-11 14:32:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520493002/20001
5 years ago (2015-12-14 06:29:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 07:55:20 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-14 07:56:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f660c2b4c8bf2e09964864054b172b45fc54dfee
Cr-Commit-Position: refs/heads/master@{#364983}

Powered by Google App Engine
This is Rietveld 408576698