Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1520453003:
[CT+Nanobench] Add gpu to nanobench config (Closed)
Description[CT+Nanobench] Add gpu to nanobench config
BUG=skia:4644
Committed: https://crrev.com/e322a36f6bcab2b3f4bb03c49cb7124a6222b474
Cr-Commit-Position: refs/heads/master@{#364433}
Patch Set 1 : Initial upload #
Total comments: 3
Messages
Total messages: 16 (6 generated)
rmistry@google.com changed reviewers: + borenet@google.com
LGTM https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps.py File content/test/ct/run_ct_skps.py (right): https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps... content/test/ct/run_ct_skps.py:58: '--config', '8888', 'gpu', You should consider putting this in the Skia repo's tools/buildbot_spec.py.
https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps.py File content/test/ct/run_ct_skps.py (right): https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps... content/test/ct/run_ct_skps.py:58: '--config', '8888', 'gpu', On 2015/12/10 19:00:36, borenet wrote: > You should consider putting this in the Skia repo's tools/buildbot_spec.py. I'll make a note to look into that.
The CQ bit was checked by rmistry@google.com
https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps.py File content/test/ct/run_ct_skps.py (right): https://codereview.chromium.org/1520453003/diff/1/content/test/ct/run_ct_skps... content/test/ct/run_ct_skps.py:58: '--config', '8888', 'gpu', On 2015/12/10 19:02:15, rmistry wrote: > On 2015/12/10 19:00:36, borenet wrote: > > You should consider putting this in the Skia repo's tools/buildbot_spec.py. > > I'll make a note to look into that. Maybe after the skia recipe module can be reused wou ld be a good time.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520453003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
rmistry@chromium.org changed reviewers: + rmistry@chromium.org
lgtm
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520453003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [CT+Nanobench] Add gpu to nanobench config BUG=skia:4644 ========== to ========== [CT+Nanobench] Add gpu to nanobench config BUG=skia:4644 Committed: https://crrev.com/e322a36f6bcab2b3f4bb03c49cb7124a6222b474 Cr-Commit-Position: refs/heads/master@{#364433} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e322a36f6bcab2b3f4bb03c49cb7124a6222b474 Cr-Commit-Position: refs/heads/master@{#364433} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
