Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/Drawer.js

Issue 1520403004: Devtools: Add metrics for drawer views being shown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 WebInspector.Drawer.prototype = { 62 WebInspector.Drawer.prototype = {
63 /** 63 /**
64 * @param {string} id 64 * @param {string} id
65 * @param {boolean=} immediate 65 * @param {boolean=} immediate
66 * @return {!Promise.<?WebInspector.Widget>} 66 * @return {!Promise.<?WebInspector.Widget>}
67 */ 67 */
68 showView: function(id, immediate) 68 showView: function(id, immediate)
69 { 69 {
70 this._innerShow(immediate); 70 this._innerShow(immediate);
71 WebInspector.userMetrics.drawerShown(id);
71 return this._extensibleTabbedPaneController.showTab(id); 72 return this._extensibleTabbedPaneController.showTab(id);
72 }, 73 },
73 74
74 showDrawer: function() 75 showDrawer: function()
75 { 76 {
76 this._innerShow(); 77 this._innerShow();
77 }, 78 },
78 79
79 wasShown: function() 80 wasShown: function()
80 { 81 {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 return this._tabbedPane.selectedTabId; 138 return this._tabbedPane.selectedTabId;
138 }, 139 },
139 140
140 initialPanelShown: function() 141 initialPanelShown: function()
141 { 142 {
142 this._initialPanelWasShown = true; 143 this._initialPanelWasShown = true;
143 }, 144 },
144 145
145 __proto__: WebInspector.VBox.prototype 146 __proto__: WebInspector.VBox.prototype
146 } 147 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698