Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2746)

Unified Diff: dm/DMSrcSink.cpp

Issue 1520403003: Prototype of RAW decoding in Skia. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Initial upload of the Prototype. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dm/DMSrcSink.cpp
diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp
index 2503dc35cec207602df6e50d9f66a518d108f2d1..e09b50d39f50be8cbeaf13d1f4bed86b321508c9 100644
--- a/dm/DMSrcSink.cpp
+++ b/dm/DMSrcSink.cpp
@@ -629,7 +629,7 @@ Error AndroidCodecSrc::draw(SkCanvas* canvas) const {
subsetHeight += (y + 1 == divisor) ? (height % divisor) : 0;
SkIRect subset = SkIRect::MakeXYWH(left, top, subsetWidth, subsetHeight);
if (!codec->getSupportedSubset(&subset)) {
- return "Could not get supported subset to decode.";
+ return Error::Nonfatal("Could not get supported subset to decode.\n");
scroggo 2015/12/18 15:56:26 Actually, this is a real error. The subsets reques
yujieqin 2016/01/06 18:47:18 Done.
}
options.fSubset = ⊂
const int scaledWidthOffset = subset.left() / fSampleSize;

Powered by Google App Engine
This is Rietveld 408576698