Prototype of RAW decoding in Skia.

gyp/codec.gyp

 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # GYP file for codec project.
 {
   'targets': [
     {
       'target_name': 'codec',
       'product_name': 'skia_codec',
       'type': 'static_library',
       'standalone_static_library': 1,
       'dependencies': [
         'core.gyp:*',
+        'raw_codec',
         'giflib.gyp:giflib',
         'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
         'libpng.gyp:libpng',
         'libwebp.gyp:libwebp',
       ],
       'cflags':[
         # FIXME: This gets around a longjmp warning. See
         # http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/113/steps/build%20most/logs/stdio
         '-Wno-clobbered -Wno-error',
       ],
@@ skipping 26 matching lines @@
         '../src/codec/SkWebpCodec.cpp',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           '../include/codec',
         ],
       },
       'defines': [
         'TURBO_HAS_SKIP',
       ],
+    }, {
+      'target_name': 'raw_codec',
+      'product_name': 'raw_codec',
+      'type': 'static_library',
+      'dependencies': [
+        'core.gyp:*',
+        'dng_sdk.gyp:dng_sdk-selector',
+        'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
+        'piex.gyp:piex-selector',
+      ],
+      'cflags':[
+        '-fexceptions',
+        '-DSK_CODEC_DECODES_RAW',

[scroggo, 2016/01/07 20:57:42]

This is a step in the right direction. But it doesn't provide a way to avoid
this target altogether.

You'll need to create a condition (in gyp/common_conditions.gypi; it should be
named "skia_codec_decodes_raw" to match this one) that determines whether to
build the raw_codec_target. This will also determine whether
SK_CODEC_DECODES_RAW is defined. That way we can tell gyp whether to build with
it or not.

It may need to depend on some variable (that does not yet exist) that specifies
whether exceptions are allowed, but I'm fine to wait until we verify that we
actually still support platforms that do not allow exceptions.

[yujieqin, 2016/01/08 14:00:12]

So we can postpone the change you mentioned for now, and keep current solution?

[scroggo, 2016/01/08 17:12:25]

You mean the change to factor out the exceptions? Yes, that is not needed. But
the change to add a condition is necessary.

[yujieqin, 2016/01/11 14:03:07]

We define the variable "skia_codec_decodes_raw" in common_variables.gypi. Then
add the condition for "SK_CODEC_DECODES_RAW" in common_conditions.gypi. Finally
includes common.gypi in codec.gyp. Is that correct?

+      ],
+      'include_dirs': [
+        '../include/codec',
+        '../include/private',
+        '../src/codec',
+        '../src/core',
+      ],
+      'sources': [
+        '../src/codec/SkRawAdapterCodec.cpp',
+        '../src/codec/SkRawCodec.cpp',
+      ],
+      'direct_dependent_settings': {
+        'include_dirs': [
+          '../include/codec',
+        ],
+        'cflags':[

[msarett, 2016/01/07 16:39:11]

IIUC, cflags is not respected on all platforms (maybe Windows or something
ignores it, I can't remember).

But if you write the following, I think it will be portable:

defines: [
  'SK_CODEC_DECODES_RAW',
]

[yujieqin, 2016/01/08 14:00:12]

Done.

+          '-DSK_CODEC_DECODES_RAW',
+        ],
+      },
+      'defines': [
+        'TURBO_HAS_SKIP',
+      ],
+      'conditions': [
+        ['OS == "ios" or OS == "mac"', {
+          'xcode_settings': {
+            'OTHER_CFLAGS': ['-fexceptions'],
+            'OTHER_CPLUSPLUSFLAGS': ['-fexceptions'],
+          },
+        }],
+      ],
     },
   ],
 }