Prototype of RAW decoding in Skia.

gyp/codec.gyp

 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # GYP file for codec project.
@@ skipping 45 matching lines @@
         '../src/codec/SkWebpCodec.cpp',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           '../include/codec',
         ],
       },
       'defines': [
         'TURBO_HAS_SKIP',
       ],
+      'conditions': [
+        ['skia_codec_decodes_raw', {
+          'dependencies': [
+            'raw_codec',
+          ],
+        },],
+      ],
+    }, {
+      'target_name': 'raw_codec',

[scroggo, 2016/01/14 15:26:38]

Please add a comment here and elsewhere (e.g. where skia_codec_decodes_raw is
defined) that raw_codec is its own target because it requires exceptions,
whereas the rest of the code does not.

(As a side note, our current tool for generating our Android makefile pools all
cflags together, so this means that *all* files will be built with -fexceptions.
I'm not sure what the implications of that are.)

[yujieqin, 2016/01/15 14:49:30]

Comments added.

+      'product_name': 'raw_codec',
+      'type': 'static_library',
+      'dependencies': [
+        'core.gyp:*',
+        'dng_sdk.gyp:dng_sdk-selector',
+        'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
+        'piex.gyp:piex-selector',
+      ],
+      'cflags':[
+        '-fexceptions',
+      ],
+      'include_dirs': [
+        '../include/codec',
+        '../include/private',
+        '../src/codec',
+        '../src/core',
+      ],
+      'sources': [
+        '../src/codec/SkRawAdapterCodec.cpp',
+        '../src/codec/SkRawCodec.cpp',
+      ],
+      'direct_dependent_settings': {
+        'include_dirs': [
+          '../include/codec',
+        ],
+        'defines': [
+          'SK_CODEC_DECODES_RAW',
+        ],
+      },
+      'defines': [
+        'SK_CODEC_DECODES_RAW',
+        'TURBO_HAS_SKIP',

[scroggo, 2016/01/14 15:26:38]

Is this necessary here? It does not directly check this compile time flag, does
it?

[yujieqin, 2016/01/15 14:49:30]

Removed.

+      ],
+      'conditions': [
+        ['OS == "ios" or OS == "mac"', {
+          'xcode_settings': {
+            'OTHER_CFLAGS': ['-fexceptions'],
+            'OTHER_CPLUSPLUSFLAGS': ['-fexceptions'],
+          },
+        }],
+      ],
     },
   ],
 }