Prototype of RAW decoding in Skia.

dm/DMSrcSink.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "DMSrcSink.h"
 #include "SamplePipeControllers.h"
 #include "SkAndroidCodec.h"
@@ skipping 611 matching lines @@
                     int subsetHeight = height / divisor;
                     const int left = x * subsetWidth;
                     const int top = y * subsetHeight;
 
                     // Increase the size of the last subset in each row or column, when the
                     // divisor does not divide evenly into the image dimensions
                     subsetWidth += (x + 1 == divisor) ? (width % divisor) : 0;
                     subsetHeight += (y + 1 == divisor) ? (height % divisor) : 0;
                     SkIRect subset = SkIRect::MakeXYWH(left, top, subsetWidth, subsetHeight);
                     if (!codec->getSupportedSubset(&subset)) {
-                        return "Could not get supported subset to decode.";
+                        return Error::Nonfatal("Could not get supported subset to decode.\n");

[scroggo, 2015/12/18 15:56:26]

Actually, this is a real error. The subsets requested here will be inside the
image's bounds, so getSupportedSubset should return true, assuming subsets are
supported at all. It looks like they are not. (This can be fixed by not
including raw etc in the extensions listed in brd_supported, as Derek
suggested.)

(Also, FYI: \n is not needed here, since Error::Nonfatal takes care of
formatting for you.)

[yujieqin, 2016/01/06 18:47:18]

Done.

                     }
                     options.fSubset = ⊂
                     const int scaledWidthOffset = subset.left() / fSampleSize;
                     const int scaledHeightOffset = subset.top() / fSampleSize;
                     void* pixels = bitmap.getAddr(scaledWidthOffset, scaledHeightOffset);
                     SkISize scaledSubsetSize = codec->getSampledSubsetDimensions(fSampleSize,
                             subset);
                     SkImageInfo subsetDecodeInfo = decodeInfo.makeWH(scaledSubsetSize.width(),
                             scaledSubsetSize.height());
 
@@ skipping 625 matching lines @@
             skr.visit<void>(i, drawsAsSingletonPictures);
         }
         SkAutoTUnref<SkPicture> macroPic(macroRec.endRecordingAsPicture());
 
         canvas->drawPicture(macroPic);
         return "";
     });
 }
 
 }  // namespace DM