Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1520393002: Adding files to libjingle .gn/.gyp. (Closed)

Created:
5 years ago by Taylor_Brandstetter
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding files to libjingle .gn/.gyp. Needed for https://codereview.webrtc.org/1507973003/ Committed: https://crrev.com/4c89c58bfcc086086570352fcb702af21c07b5ee Cr-Commit-Position: refs/heads/master@{#365126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520393002/1
5 years ago (2015-12-14 19:36:04 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-14 19:36:08 UTC) #5
Taylor_Brandstetter
tommi: PTAL. This is just adding stub files to the chromium libjingle build.
5 years ago (2015-12-14 19:38:48 UTC) #8
tommi (sloooow) - chröme
lgtm
5 years ago (2015-12-14 21:01:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520393002/1
5 years ago (2015-12-14 21:03:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 23:39:00 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-14 23:39:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c89c58bfcc086086570352fcb702af21c07b5ee
Cr-Commit-Position: refs/heads/master@{#365126}

Powered by Google App Engine
This is Rietveld 408576698