Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 152033005: Use MessagePumpDispatcher instead of MessageFilter (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use MessagePumpDispatcher instead of MessageFilter This is a preparation to remove base::MessageLoopForUI::MessageFilter. BUG=330735, 319122 TEST=done by manually executing cloud_print_service_config.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249234

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M cloud_print/service/win/cloud_print_service_config.cc View 3 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yukawa
Hi Carlos, Scott, Vitaly, I'd like to hear your comments. I'm wondering if we can ...
6 years, 10 months ago (2014-02-05 13:15:27 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-02-05 20:16:20 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 10 months ago (2014-02-05 20:26:11 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 20:27:10 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 20:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/152033005/50001
6 years, 10 months ago (2014-02-05 20:32:25 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 02:33:07 UTC) #7
Message was sent while issue was closed.
Change committed as 249234

Powered by Google App Engine
This is Rietveld 408576698