Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520313002: Don't assume correct image format in CopyVpxImageToVideoFrame() (Closed)

Created:
5 years ago by wdzierzanowski
Modified:
5 years ago
Reviewers:
mcasas, DaleCurtis, *vignesh
CC:
chromium-reviews, feature-media-reviews_chromium.org, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't assume correct image format in CopyVpxImageToVideoFrame() The data arriving inside the |vpx_image| struct is not guaranteed by libvpx to be in one of the formats supported by VpxVideoDecoder. BUG=569574 TEST=Loading http://shion.ru/crash.webm should result in video decoding error Committed: https://crrev.com/8d8eac333eba5cf62ed5d6353517ca345d599b1a Cr-Commit-Position: refs/heads/master@{#365213}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M media/filters/vpx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 4 chunks +21 lines, -10 lines 2 comments Download

Messages

Total messages: 16 (7 generated)
wdzierzanowski
Hi Dale, could you PTAL?
5 years ago (2015-12-14 15:51:19 UTC) #2
DaleCurtis
+vigneshv for a look-over. lgtm though.
5 years ago (2015-12-14 17:47:04 UTC) #5
vignesh
On 2015/12/14 17:47:04, DaleCurtis wrote: > +vigneshv for a look-over. lgtm though. lgtm. thanks!
5 years ago (2015-12-15 08:04:31 UTC) #6
wdzierzanowski
On 2015/12/15 08:04:31, vignesh wrote: > On 2015/12/14 17:47:04, DaleCurtis wrote: > > +vigneshv for ...
5 years ago (2015-12-15 08:22:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520313002/1
5 years ago (2015-12-15 08:22:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 09:11:14 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d8eac333eba5cf62ed5d6353517ca345d599b1a Cr-Commit-Position: refs/heads/master@{#365213}
5 years ago (2015-12-15 09:11:52 UTC) #12
mcasas
Sorry, delayed review. Thanks for doing this! https://codereview.chromium.org/1520313002/diff/1/media/filters/vpx_video_decoder.cc File media/filters/vpx_video_decoder.cc (right): https://codereview.chromium.org/1520313002/diff/1/media/filters/vpx_video_decoder.cc#newcode556 media/filters/vpx_video_decoder.cc:556: codec_format = ...
5 years ago (2015-12-15 17:04:54 UTC) #14
vignesh
5 years ago (2015-12-15 17:10:23 UTC) #15
Message was sent while issue was closed. 
https://codereview.chromium.org/1520313002/diff/1/media/filters/vpx_video_dec...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/1520313002/diff/1/media/filters/vpx_video_dec...
media/filters/vpx_video_decoder.cc:556: codec_format = vpx_codec_alpha_ ?
PIXEL_FORMAT_YV12A : PIXEL_FORMAT_YV12;
On 2015/12/15 17:04:54, mcasas wrote:
> VpxVideoDecoder should not be used for YV12 
> if there is FFmpeg enabled  [1, 2], so I wonder 
> if we should avoid this format or add here another
> #if !defined(DISABLE_FFMPEG_VIDEO_DECODERS)
> or DCHECK() it or sth on those lines?
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/vpx_...
> [2]
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/vpx_...

The comment on [1] may be perceived as ambiguous. What it means is that
VpxDecoder accepts YV12A VP8 and *all* VP9 content (including YV12). The YV12
format here is intended for VP9.

So nothing needs to be done here as far as i understand.

Powered by Google App Engine
This is Rietveld 408576698