Issue 15203002: Revert "Implement Object.getNotifier(obj).performChange()" (r14696)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15203002: Revert "Implement Object.getNotifier(obj).performChange()" (r14696) (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Implement Object.getNotifier(obj).performChange()" (r14696) Reverts r14696 because it caused debug assertion failures when running test/mjsunit/harmony/object-observe.js TBR=rossberg Committed: https://code.google.com/p/v8/source/detail?r=14697

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -514 lines)			Patch
M	src/messages.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/object-observe.js	View	7 chunks	+11 lines, -183 lines	0 comments	Download
M	test/mjsunit/harmony/object-observe.js	View	9 chunks	+20 lines, -328 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adamk

7 years, 7 months ago (2013-05-15 18:47:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14697 (presubmit successful).

Expand Messages | Collapse Messages