Add token invariant to DiagnosticReporter

Add token invariant to DiagnosticReporter

Closes #3675

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5235fde7ffd55a184eb79306cfeb0344d560fc7

[Johnni Winther, 2015-12-14 14:41:35]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-12-14 22:54:44]

lgtm.

It might be worth documenting somewhere what we check and what we don't, so we
know in the future how to bypass the check if we need to (like you had to do for
the super-use and initializer hints). For example, maybe at
reportMessage/createMessage you can say that in checked-mode we will verify that
currentElement contains the given spannable node, unless you give us a prebuilt
SourceSpan, in which case we don't validate it.

https://codereview.chromium.org/1520293002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1520293002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1049:
reporter.withCurrentElement(annotation.annotatedElement.enclosingElement, () =>
measure(() {
nit => 80 col

[Johnni Winther, 2015-12-15 09:35:51]

On 2015/12/14 22:54:44, Siggi Cherem (dart-lang) wrote:
> lgtm.
> 
> It might be worth documenting somewhere what we check and what we don't, so we
> know in the future how to bypass the check if we need to (like you had to do
for
> the super-use and initializer hints). For example, maybe at
> reportMessage/createMessage you can say that in checked-mode we will verify
that
> currentElement contains the given spannable node, unless you give us a
prebuilt
> SourceSpan, in which case we don't validate it.
> 

I've added comments to DiagnosticReporter.spanFromSpannable. The change on
initializer and super-use don't be bypass the check but ensure that we compute
the nodes in the right context.

[Johnni Winther, 2015-12-15 10:28:01]

https://codereview.chromium.org/1520293002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1520293002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1049:
reporter.withCurrentElement(annotation.annotatedElement.enclosingElement, () =>
measure(() {
On 2015/12/14 22:54:44, Siggi Cherem (dart-lang) wrote:
> nit => 80 col

Done.

[Johnni Winther, 2015-12-15 10:36:04]

Description was changed from

==========
Add token invariant to DiagnosticReporter

Closes #3675
==========

to

==========
Add token invariant to DiagnosticReporter

Closes #3675

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5235fde7ffd55a184eb79306cfeb0344d560fc7
==========

[Johnni Winther, 2015-12-15 10:36:06]

Committed patchset #3 (id:40001) manually as
c5235fde7ffd55a184eb79306cfeb0344d560fc7 (presubmit successful).