Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1520253002: Remove ScopedVector from http_auth_handler_mock (Closed)

Created:
5 years ago by Olli Raula
Modified:
5 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from http_auth_handler_mock BUG=554289 Committed: https://crrev.com/737cf49e0774e4bb10b204b1bbc76aecd5d65e1d Cr-Commit-Position: refs/heads/master@{#365195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M net/http/http_auth_handler_mock.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Olli Raula
Could you review?
5 years ago (2015-12-14 14:15:04 UTC) #3
mmenke
On 2015/12/14 14:15:04, Olli Raula wrote: > Could you review? LGTM
5 years ago (2015-12-14 16:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520253002/1
5 years ago (2015-12-15 07:00:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 07:04:02 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 07:04:39 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/737cf49e0774e4bb10b204b1bbc76aecd5d65e1d
Cr-Commit-Position: refs/heads/master@{#365195}

Powered by Google App Engine
This is Rietveld 408576698