mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl - Issue 1520153002: [mojo] Allow value deserialization to fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

Issue 1520153002: [mojo] Allow value deserialization to fail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindings-3-misc-support

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

index 24cc76725aec0243bfcfcaccccb4814d6dafa02f..5c14ea0da15179a91b67489f27c199c960cf6626 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

@@ -16,14 +16,16 @@ void Serialize_({{struct.name}}Ptr input, mojo::internal::Buffer* buf,

}

-void Deserialize_(internal::{{struct.name}}_Data* input,

+bool Deserialize_(internal::{{struct.name}}_Data* input,

{{struct.name}}Ptr* output,

mojo::internal::SerializationContext* context) {

+ bool success = true;

if (input) {

{{struct.name}}Ptr result({{struct.name}}::New());

- {{struct_macros.deserialize(struct, "input", "result->%s", "context")|indent(2)}}

+ {{struct_macros.deserialize(struct, "input", "result->%s", "context", "success")|indent(2)}}

*output = result.Pass();

} else {

output->reset();

}

+ return success;

}