Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1520113002: New Mojom parser: Remove dependency on CGO. (Closed)

Created:
5 years ago by rudominer
Modified:
5 years ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom parser: Remove dependency on CGO. BUG=#593 We take advantage of the go compiler's build tags feature. We can conditionally include the mojo system impl cgo files only when the build tag "include_mojo_cgo" is set. We do not set this tag when building the Mojom parser. We are also able to eliminate the separate entry for "Go mojom parser serialization tests". The serialization test can now be run as a pure go test like all the others. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/60b06a6a6178a00de346eabad0c71eb7519e160b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -47 lines) Patch
M mojo/go/rules.gni View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/go/system/system_android.go View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/go/system/system_linux.go View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/go/system/system_nacl.go View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/tools/data/gotests View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +0 lines, -5 lines 0 comments Download
M mojom/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download
M mojom/mojom_parser/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
rudominer
Hi Alex, ptal.
5 years ago (2015-12-14 16:26:49 UTC) #8
azani
lgtm
5 years ago (2015-12-14 20:56:37 UTC) #9
rudominer
5 years ago (2015-12-14 20:58:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
60b06a6a6178a00de346eabad0c71eb7519e160b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698