fpdfsdk/src/javascript/Document.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/Document.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/Document.cpp

diff --git a/fpdfsdk/src/javascript/Document.cpp b/fpdfsdk/src/javascript/Document.cpp

index b0ca69b5bad2c7adad593bb29440aa2d2567b9a7..f4a1090c3d5985ab79ecde74e5e0235300bce96b 100644

--- a/fpdfsdk/src/javascript/Document.cpp

+++ b/fpdfsdk/src/javascript/Document.cpp

@@ -1259,14 +1259,14 @@ void IconTree::InsertIconElement(IconElement* pNewIcon) {

if (!pNewIcon)

return;

- if (m_pHead == NULL && m_pEnd == NULL) {

- m_pHead = m_pEnd = pNewIcon;

- m_iLength++;

- } else {

+ if (m_pHead || m_pEnd) {

m_pEnd->NextIcon = pNewIcon;

m_pEnd = pNewIcon;

- m_iLength++;

+ } else {

+ m_pHead = pNewIcon;

+ m_pEnd = pNewIcon;

}

+ m_iLength++;

}

void IconTree::DeleteIconTree() {

« no previous file with comments | « fpdfsdk/src/fxedit/fxet_edit.cpp ('k') | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | no next file with comments »