fpdfsdk/src/fpdf_sysfontinfo.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_sysfontinfo.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_sysfontinfo.cpp

diff --git a/fpdfsdk/src/fpdf_sysfontinfo.cpp b/fpdfsdk/src/fpdf_sysfontinfo.cpp

index 71fa94472c59050643a7f351547a0de6b9346778..655c4a22bb096dcc45b8325d42c186b8d19ffd26 100644

--- a/fpdfsdk/src/fpdf_sysfontinfo.cpp

+++ b/fpdfsdk/src/fpdf_sysfontinfo.cpp

@@ -55,7 +55,7 @@ class CFX_ExternalFontInfo final : public IFX_SystemFontInfo {

}

FX_BOOL GetFaceName(void* hFont, CFX_ByteString& name) override {

- if (m_pInfo->GetFaceName == NULL)

+ if (!m_pInfo->GetFaceName)

return FALSE;

FX_DWORD size = m_pInfo->GetFaceName(m_pInfo, hFont, NULL, 0);

if (size == 0)

@@ -170,7 +170,7 @@ static void DefaultDeleteFont(struct _FPDF_SYSFONTINFO* pThis, void* hFont) {

DLLEXPORT FPDF_SYSFONTINFO* STDCALL FPDF_GetDefaultSystemFontInfo() {

IFX_SystemFontInfo* pFontInfo = IFX_SystemFontInfo::CreateDefault(nullptr);

- if (pFontInfo == NULL)

+ if (!pFontInfo)

return NULL;

FPDF_SYSFONTINFO_DEFAULT* pFontInfoExt =

« no previous file with comments | « fpdfsdk/src/fpdf_dataavail.cpp ('k') | fpdfsdk/src/fpdf_transformpage.cpp » ('j') | no next file with comments »