core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

index 640e8671f8cfbc4db6edbb82cc8478401a481f37..10b0272b5246211dc5e2f5f07105b0d8e95db52b 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

@@ -51,7 +51,7 @@ CPDF_Dictionary* CPDF_Image::InitJPEG(uint8_t* pData, FX_DWORD size) {

m_bIsMask = FALSE;

m_Width = width;

m_Height = height;

- if (m_pStream == NULL) {

+ if (!m_pStream) {

m_pStream = new CPDF_Stream(NULL, 0, NULL);

}

return pDict;

@@ -367,7 +367,7 @@ void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap,

dest_buf = NULL;

}

- if (m_pStream == NULL) {

+ if (!m_pStream) {

m_pStream = new CPDF_Stream(NULL, 0, NULL);

}

if (!bStream) {