core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp

diff --git a/core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp b/core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp

index fba3a2b031b94824e0fa8256048452b081c6e34a..90091deaac0ccf2966bcc2a22de06fdc1cd2ff00 100644

--- a/core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp

+++ b/core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp

@@ -105,7 +105,7 @@ FX_WORD FPDFAPI_CIDFromCharCode(const FXCMAP_CMap* pMap, FX_DWORD charcode) {

}

FX_WORD code = (FX_WORD)charcode;

while (1) {

- if (pMap->m_pWordMap == NULL) {

+ if (!pMap->m_pWordMap) {

return 0;

}

if (pMap->m_WordMapType == FXCMAP_CMap::Single) {