Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: fpdfsdk/src/javascript/Document.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull
Patch Set: self review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/javascript/Document.cpp
diff --git a/fpdfsdk/src/javascript/Document.cpp b/fpdfsdk/src/javascript/Document.cpp
index b0ca69b5bad2c7adad593bb29440aa2d2567b9a7..4254b588f5697ce69b563778924b88663e3dfebf 100644
--- a/fpdfsdk/src/javascript/Document.cpp
+++ b/fpdfsdk/src/javascript/Document.cpp
@@ -1259,14 +1259,13 @@ void IconTree::InsertIconElement(IconElement* pNewIcon) {
if (!pNewIcon)
return;
- if (m_pHead == NULL && m_pEnd == NULL) {
- m_pHead = m_pEnd = pNewIcon;
- m_iLength++;
- } else {
+ if (m_pHead || m_pEnd) {
m_pEnd->NextIcon = pNewIcon;
m_pEnd = pNewIcon;
- m_iLength++;
+ } else {
+ m_pHead = m_pEnd = pNewIcon;
Tom Sepez 2015/12/14 18:27:00 Nit: one per line so long as you're re-writing thi
Lei Zhang 2015/12/15 01:58:36 Done.
}
+ m_iLength++;
}
void IconTree::DeleteIconTree() {

Powered by Google App Engine
This is Rietveld 408576698