fpdfsdk/src/fpdf_transformpage.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_transformpage.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: self review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_transformpage.cpp

diff --git a/fpdfsdk/src/fpdf_transformpage.cpp b/fpdfsdk/src/fpdf_transformpage.cpp

index 429a9d5cd49546e175e057edfae36e93aae446b7..43250fb90e2c1b5ef51a78d2fc4e99d8fa4cc24a 100644

--- a/fpdfsdk/src/fpdf_transformpage.cpp

+++ b/fpdfsdk/src/fpdf_transformpage.cpp

@@ -195,7 +195,7 @@ FPDFPageObj_TransformClipPath(FPDF_PAGEOBJECT page_object,

double e,

double f) {

CPDF_PageObject* pPageObj = (CPDF_PageObject*)page_object;

- if (pPageObj == NULL)

+ if (!pPageObj)

return;

CFX_AffineMatrix matrix((FX_FLOAT)a, (FX_FLOAT)b, (FX_FLOAT)c, (FX_FLOAT)d,

(FX_FLOAT)e, (FX_FLOAT)f);

@@ -226,7 +226,7 @@ DLLEXPORT void STDCALL FPDF_DestroyClipPath(FPDF_CLIPPATH clipPath) {

void OutputPath(CFX_ByteTextBuf& buf, CPDF_Path path) {

const CFX_PathData* pPathData = path;

- if (pPathData == NULL)

+ if (!pPathData)

return;

FX_PATHPOINT* pPoints = pPathData->GetPoints();